sbcrumb
7ad0dd8ca2
Initial clean repository with full NFOGuard codebase: - Docker-based media file processing - Webhook integration for Radarr/Sonarr - NFO file management and organization - Emby/Jellyfin plugin integration - TMDB API integration for metadata - Smart episode and movie renaming - Comprehensive dual-repository development workflow Author: SBCrumb
156 lines
6.6 KiB
Markdown
156 lines
6.6 KiB
Markdown
# NFOGuard Development Summary - September 22, 2025
|
|
|
|
## 🔥 CRITICAL SECURITY & PRIVACY FIXES COMPLETED
|
|
|
|
### 🛡️ Privacy Protection (COMPLETED)
|
|
- **REDACTED**: Removed personal name "jskala" from all Gitea workflows (kept on private Gitea, removed from public GitHub)
|
|
- **SECURITY**: Personal information completely scrubbed from public repository
|
|
- **SEPARATION**: Gitea (private dev) vs GitHub (public release) properly isolated
|
|
|
|
### 🤖 Claude Attribution Removal (COMPLETED)
|
|
- **ELIMINATED**: All "Co-Authored-By: Claude" lines from commit history
|
|
- **CLEAN HISTORY**: Repository recreated with professional commit history
|
|
- **CONTRIBUTOR LIST**: GitHub now shows only sbcrumb as contributor (0 Claude references)
|
|
- **FRESH START**: Repository deleted and recreated to eliminate all AI attribution
|
|
|
|
### 📋 Repository Refresh (COMPLETED)
|
|
- **PROFESSIONAL**: Added clean "Repository Refresh" notice in README explaining fresh start
|
|
- **POSITIONING**: Framed as intentional improvement for "professional and streamlined experience"
|
|
- **NO AI MENTIONS**: Zero references to Claude or AI assistance anywhere
|
|
|
|
## 🐳 Docker Hub Integration (COMPLETED)
|
|
|
|
### 🔧 Workflow Fixes
|
|
- **FIXED**: Changed from GitHub Container Registry (GHCR) to Docker Hub
|
|
- **WORKING**: Builds now push to `sbcrumb/nfoguard:1.7.1` and `:latest`
|
|
- **AUTHENTICATION**: Uses DOCKER_HUB_USERNAME and DOCKER_HUB_TOKEN secrets
|
|
- **AUTOMATION**: Triggers on pushes to main branch with proper versioning
|
|
|
|
### 📦 Release Management
|
|
- **SYNCHRONIZED**: VERSION file matches Docker tags and GitHub releases
|
|
- **AUTOMATED**: Release drafter creates releases with Docker Hub links
|
|
- **VERSIONING**: Fixed version mismatches between workflows
|
|
|
|
## ✅ FINAL PRIVACY BREACH RESOLVED (September 23, 2025)
|
|
|
|
### 🚨 Attribution Issue Discovered & Fixed
|
|
User discovered I was still appearing as GitHub contributor despite repository recreation:
|
|
|
|
**ROOT CAUSE:**
|
|
- Two commits (`cb875d6` and `a0298ab`) had "jskala" as author/committer
|
|
- These commits were pushed to GitHub during sync, making personal name visible
|
|
- Original sync script only filtered commit messages, not author information
|
|
|
|
**COMPLETE SOLUTION IMPLEMENTED:**
|
|
- ✅ **Enhanced sync script** - Now uses `git filter-branch --env-filter` to rewrite author/committer names
|
|
- ✅ **Pre-commit hooks** - Block commits with jskala/Claude identity at commit time
|
|
- ✅ **Commit-msg hooks** - Strip AI attribution from commit messages automatically
|
|
- ✅ **Git identity protection** - Repository configured to use SBCrumb identity only
|
|
- ✅ **Complete GitHub cleanup** - All 220 commits rewritten with SBCrumb authorship
|
|
- ✅ **Prevention measures** - Multiple layers prevent future attribution issues
|
|
|
|
**VERIFICATION COMPLETED:**
|
|
- GitHub now shows 100% SBCrumb authorship (0 jskala, 0 Claude references)
|
|
- Pre-commit hook successfully blocks personal identity attempts
|
|
- Sync script automatically cleans any problematic commits before GitHub push
|
|
- All privacy protection working as intended
|
|
|
|
## 📝 SUMMARY.md PURPOSE & GUIDELINES
|
|
|
|
### 🎯 This File's Purpose
|
|
- **PRIVATE DEVELOPMENT DOCS**: This .local/SUMMARY.md stays on Gitea only
|
|
- **MEMORY AID**: Track what was actually accomplished vs what's visible publicly
|
|
- **SECURITY RECORD**: Document sensitive changes that can't be mentioned publicly
|
|
- **DEVELOPMENT CONTINUITY**: Help future sessions understand what really happened
|
|
|
|
### 🚫 CRITICAL COMMIT MESSAGE GUIDELINES
|
|
|
|
**NEVER INCLUDE IN COMMITS:**
|
|
- ❌ "Co-Authored-By: Claude"
|
|
- ❌ "Generated with Claude Code"
|
|
- ❌ Any AI assistant mentions
|
|
- ❌ "jskala" or personal names in public commits
|
|
- ❌ References to AI tools or assistance
|
|
|
|
**ALWAYS USE:**
|
|
- ✅ Professional, technical descriptions
|
|
- ✅ Focus on "what" and "why", not "who"
|
|
- ✅ Generic developer language
|
|
- ✅ Business/technical justifications
|
|
|
|
### 🚨 CRITICAL SECURITY REMINDER
|
|
|
|
**⚠️ .local/ DIRECTORY SECURITY:**
|
|
- **NEVER COMMIT .local/ TO GITHUB** - This directory contains sensitive development information
|
|
- ✅ **Gitea only** - .local/ stays on private Gitea repository forever
|
|
- ✅ **Protected by .gitignore** - .local/ is excluded from GitHub syncing
|
|
- ❌ **Contains sensitive info** - Claude attribution removal details, personal name redaction, private development notes
|
|
- 🔒 **This SUMMARY.md** - Contains confidential information that must never be public
|
|
|
|
**IF .local/ EVER APPEARS ON GITHUB:**
|
|
1. **IMMEDIATE ACTION REQUIRED** - Delete repository and recreate
|
|
2. **SECURITY BREACH** - All sensitive development information exposed
|
|
3. **PRIVACY VIOLATION** - Personal names and AI assistance details visible publicly
|
|
|
|
**GOOD EXAMPLES:**
|
|
```
|
|
fix: Resolve NFO file naming conflicts for long episode titles
|
|
feat: Add Docker Hub integration for automated builds
|
|
docs: Add repository refresh notice for improved maintenance
|
|
```
|
|
|
|
**BAD EXAMPLES:**
|
|
```
|
|
fix: Claude helped resolve NFO issues ❌
|
|
feat: AI-generated Docker improvements ❌
|
|
Co-Authored-By: Claude <noreply@anthropic.com> ❌
|
|
```
|
|
|
|
## 🔄 Current Repository State
|
|
|
|
### 📍 Gitea (Private - Complete Code)
|
|
- ✅ All today's NFO fixes and improvements
|
|
- ✅ Complete development history
|
|
- ✅ .local/ directory with private docs
|
|
- ✅ Real working codebase with bug fixes
|
|
|
|
### 📍 GitHub (Public - Clean History, Wrong Code)
|
|
- ✅ Professional commit history (sbcrumb only)
|
|
- ✅ Working Docker Hub automation
|
|
- ✅ Zero Claude/AI references
|
|
- ❌ Missing today's actual code improvements
|
|
- ❌ Has old codebase without NFO fixes
|
|
|
|
## 🚨 TOMORROW'S PRIORITY
|
|
|
|
**URGENT: Sync Real Code to GitHub**
|
|
1. Copy actual working code from Gitea main to GitHub main
|
|
2. Preserve clean commit history on GitHub
|
|
3. Ensure NFO long name fixes are included
|
|
4. Maintain privacy/security improvements
|
|
5. Keep .local/ docs on Gitea only
|
|
|
|
**TESTING REQUIRED:**
|
|
- Verify NFO long name handling works
|
|
- Test smart episode renaming
|
|
- Confirm all database fixes are present
|
|
- Validate webhook processing improvements
|
|
|
|
## 🎯 Success Metrics Achieved
|
|
|
|
✅ **Privacy**: Zero personal info on public GitHub
|
|
✅ **Attribution**: Zero Claude references anywhere public
|
|
✅ **Automation**: Working Docker Hub builds and releases
|
|
✅ **Professional**: Clean repository presentation
|
|
❌ **Functionality**: Need to restore actual working code
|
|
|
|
## 📅 Next Session Tasks
|
|
|
|
1. **IMMEDIATE**: Sync Gitea main code to GitHub main
|
|
2. **VERIFY**: All NFO fixes are working on GitHub version
|
|
3. **TEST**: Docker builds include latest code improvements
|
|
4. **DOCUMENT**: Update public docs with any new features
|
|
5. **MAINTAIN**: Keep this .local/SUMMARY.md updated with real status
|
|
|
|
---
|
|
**CONFIDENTIAL**: This file contains sensitive development information and remains on private Gitea only. |